Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18409#discussion_r123823359
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/debug/package.scala ---
@@ -50,23 +50,38 @@ package object debug {
// scalastyle:on println
}
+ /** Generate codegen debug info */
def codegenString(plan: SparkPlan): String = {
+ val codegenSeq = codegenStringSeq(plan)
+ var output = s"Found ${codegenSeq.size} WholeStageCodegen subtrees.\n"
+ for (((subtree, code), i) <- codegenSeq.zipWithIndex) {
+ output += s"== Subtree ${i + 1} / ${codegenSeq.size} ==\n"
+ output += subtree
+ output += "\nGenerated code:\n"
+ output += s"${code}\n"
+ }
+ output
+ }
+
+ /**
+ * Find WholeStageCodegenExec subtrees in query plan and do codegen for
each of them
+ *
+ * @param plan the query plan for codegen
+ * @return Sequence of WholeStageCodegen subtrees and corresponding
codegen
+ */
+ def codegenStringSeq(plan: SparkPlan): Seq[(String, String)] = {
val codegenSubtrees = new
collection.mutable.HashSet[WholeStageCodegenExec]()
plan transform {
case s: WholeStageCodegenExec =>
codegenSubtrees += s
s
case s => s
}
- var output = s"Found ${codegenSubtrees.size} WholeStageCodegen
subtrees.\n"
- for ((s, i) <- codegenSubtrees.toSeq.zipWithIndex) {
- output += s"== Subtree ${i + 1} / ${codegenSubtrees.size} ==\n"
- output += s
- output += "\nGenerated code:\n"
- val (_, source) = s.doCodeGen()
- output += s"${CodeFormatter.format(source)}\n"
+ codegenSubtrees.toSeq.map {
+ subtree =>
--- End diff --
Please collapse the above two lines into a single line
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
