Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17222#discussion_r123871026
  
    --- Diff: python/pyspark/sql/tests.py ---
    @@ -481,6 +481,20 @@ def test_udf_registration_returns_udf(self):
                 df.select(add_three("id").alias("plus_three")).collect()
             )
     
    +    def test_non_existed_udf(self):
    +        try:
    +            self.spark.udf.registerJavaFunction("udf1", "non_existed_udf")
    +            self.fail("should fail due to can not load java udf class")
    +        except AnalysisException as e:
    --- End diff --
    
    shall we use `self.assertRaises` like other tests?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to