Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18106#discussion_r123884830 --- Diff: R/pkg/tests/fulltests/test_sparkSQL.R --- @@ -1382,8 +1382,8 @@ test_that("column functions", { c20 <- to_timestamp(c) + to_timestamp(c, "yyyy") + to_date(c, "yyyy") c21 <- posexplode_outer(c) + explode_outer(c) c22 <- not(c) - c23 <- trunc(c, "year") + trunc(c, "yyyy") + trunc(c, "yy") + - trunc(c, "month") + trunc(c, "mon") + trunc(c, "mm") + c23 <- trunc(to_date(c), "year") + trunc(to_date(c), "yyyy") + trunc(to_date(c), "yy") + + trunc(to_date(c), "month") + trunc(to_date(c), "mon") + trunc(to_date(c), "mm") --- End diff -- that's a good point. fortunately (?) trunc was only added to R in 2.3.0, so I think we need to make sure (manually, add unit test) that trunc works on date columns and numeric columns
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org