Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/17995#discussion_r123919667
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/ChiSqSelector.scala ---
@@ -128,7 +130,8 @@ private[feature] trait ChiSqSelectorParams extends
Params
final val selectorType = new Param[String](this, "selectorType",
"The selector type of the ChisqSelector. " +
"Supported options: " +
OldChiSqSelector.supportedSelectorTypes.mkString(", "),
-
ParamValidators.inArray[String](OldChiSqSelector.supportedSelectorTypes))
+ (value: String) =>
OldChiSqSelector.supportedSelectorTypes.map(_.toLowerCase(Locale.ROOT))
--- End diff --
Supported selector types should always be stored as lower case, please
update corresponding code snippet in ```mllib.feature.ChiSqSelector``` from:
```
private[spark] val NumTopFeatures: String = "numTopFeatures"
......
```
to
```
private[spark] val NumTopFeatures: String = "numTopFeatures".toLowerCase
......
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
