Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18418#discussion_r124081617
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -736,7 +736,27 @@ class CodegenContext {
// Cannot split these expressions because they are not created from
a row object.
return expressions.mkString("\n")
}
- splitExpressions(expressions, "apply", ("InternalRow", row) :: Nil)
+ splitExpressions(row, expressions, Seq.empty)
--- End diff --
Do we need the check in lines 735-738? Now, we do the same check at lines
754-757, too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
