Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18428#discussion_r124161588
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tuning/CrossValidatorSuite.scala ---
@@ -156,6 +156,46 @@ class CrossValidatorSuite
CrossValidatorSuite.compareParamMaps(cv.getEstimatorParamMaps,
cv2.getEstimatorParamMaps)
}
+ test("read/write: CrossValidator with nested estimator") {
+ val ova = new OneVsRest()
+ .setClassifier(new LogisticRegression)
+ val evaluator = new BinaryClassificationEvaluator()
+ .setMetricName("areaUnderPR") // not default metric
+
+
+ val classifier1 = new LogisticRegression().setRegParam(2.0)
+ val classifier2 = new LogisticRegression().setRegParam(3.0)
+ val paramMaps = new ParamGridBuilder()
+ .addGrid(ova.classifier, Array(classifier1, classifier2))
--- End diff --
Add comment that it is important to test Param values which inherit from
Params.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
