Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/16699#discussion_r124233224 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala --- @@ -406,6 +437,14 @@ object GeneralizedLinearRegression extends DefaultParamsReadable[GeneralizedLine private[regression] val epsilon: Double = 1E-16 + /** Checks whether weight column is set and nonempty */ + private[regression] def isSetWeightCol(params: GeneralizedLinearRegressionBase): Boolean = --- End diff -- Can we move the two functions to ```GeneralizedLinearRegressionBase``` and rename as ```hasWeightCol```, just like ```hasLinkPredictionCol```?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org