Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2571#discussion_r18136340
--- Diff: ec2/spark_ec2.py ---
@@ -626,43 +626,43 @@ def wait_for_cluster(conn, wait_secs, master_nodes,
slave_nodes):
def get_num_disks(instance_type):
# From
http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/InstanceStorage.html
# Updated 2014-6-20
+ # For easy maintainability, please keep this manually-inputted
dictionary sorted by key.
disks_by_instance = {
--- End diff --
This dictionary had a duplicate key, `t1.micro`. To make it easier to
prevent this kind of mistake again, I sorted the keys. This is how they appear
on the [source
page](http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/InstanceStorage.html),
too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]