Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18159#discussion_r124739262 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -2659,6 +2668,13 @@ private[spark] object Utils extends Logging { redact(redactionPattern, kvs.toArray) } + def average[T](ts: Iterable[T])(implicit num: Numeric[T]): Double = { --- End diff -- shall we require array type parameter? We are calling `size` twice in this method, which can be very slow if the input is not indexed seq.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org