Github user jinxing64 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r124749254
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java
---
@@ -257,4 +257,31 @@ public Properties cryptoConf() {
return CryptoUtils.toCryptoConf("spark.network.crypto.config.",
conf.getAll());
}
+ /**
+ * When memory usage of Netty is above this water mark, it's regarded as
memory shortage.
--- End diff --
Sorry, you mean:
1. the change(`spark.network.netty.memCostWaterMark`) in this pr is ok
2. we merge `spark.executor.memory`(heap size) and
`spark.memory.offHeap.size` (off-heap size, used by Tungsten) to be one in
executor memory config.
Do I understand correctly ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
