Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/16989#discussion_r124886621 --- Diff: common/network-common/src/main/java/org/apache/spark/network/server/OneForOneStreamManager.java --- @@ -95,6 +97,25 @@ public ManagedBuffer getChunk(long streamId, int chunkIndex) { } @Override + public ManagedBuffer openStream(String streamChunkId) { --- End diff -- @jinxing64 this breaks old shuffle service. We should avoid change server side codes. Right now I just disabled this feature in #18467
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org