Github user ajbozarth commented on a diff in the pull request:
https://github.com/apache/spark/pull/18464#discussion_r125097663
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/ui/WorkerPage.scala ---
@@ -112,7 +112,15 @@ private[ui] class WorkerPage(parent: WorkerWebUI)
extends WebUIPage("") {
<td>
<ul class="unstyled">
<li><strong>ID:</strong> {executor.appId}</li>
- <li><strong>Name:</strong> {executor.appDesc.name}</li>
+ <li><strong>Name:</strong>
+ {
+ if ({executor.state == ExecutorState.RUNNING}) {
+ <a href={executor.appDesc.appUiUrl}>
{executor.appDesc.name}</a>
--- End diff --
Thanks @dongjoon-hyun I missed that in my review, we definitely need that
non-empty check
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
