Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18159#discussion_r125217353
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -47,10 +56,56 @@ trait RunnableCommand extends logical.Command {
}
/**
+ * A trait for classes that can update its metrics of data writing
operation.
+ */
+trait MetricUpdater {
+
+ val metrics: Map[String, SQLMetric]
+
+ /**
+ * Callback function that update metrics collected from the writing
operation.
+ */
+ protected def callbackMetricsUpdater(writeSummaries:
Seq[ExecutedWriteSummary]): Unit = {
--- End diff --
Good for me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
