Github user derrickburns commented on the pull request:
https://github.com/apache/spark/pull/2419#issuecomment-57238377
Will do
Sent from my iPhone
> On Sep 29, 2014, at 2:32 PM, Xiangrui Meng <notificati...@github.com>
wrote:
>
> @derrickburns Could you merge the PR cleanly? For the closure
serialization, just go with the spores style, assign a class member using to a
val and reference the val in the closure. Creating a new class with a single
object is not necessary.
>
> For randomization, we should try to make the algorithm deterministic
given a random seed. Then we can fix the random seed for tests.
>
> â
> Reply to this email directly or view it on GitHub.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
