Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18481#discussion_r125349671
--- Diff: R/pkg/R/functions.R ---
@@ -2875,9 +2875,9 @@ setMethod("ifelse",
#' @details
#' \code{cume_dist}: Returns the cumulative distribution of values within
a window partition,
#' i.e. the fraction of rows that are below the current row:
-#' number of values before (and including) x / total number of rows in the
partition.
+#' (number of values before and including x) / (total number of rows in
the partition)
#' This is equivalent to the \code{CUME_DIST} function in SQL.
--- End diff --
This is not a formula, right? Thought this is pretty clear. Not sure what
is the ask. I can just add a period after the `partition)`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
