Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2542#discussion_r18189290
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -110,8 +110,20 @@ abstract class LogicalPlan extends
QueryPlan[LogicalPlan] with Logging {
}
if (resolver(option.name, remainingParts.head)) {
- // Preserve the case of the user's attribute reference.
- (option.withName(remainingParts.head), remainingParts.tail.toList)
:: Nil
+ (option.dataType, remainingParts) match {
--- End diff --
It might be a little clearer to do do something like:
```scala
val optionalNestedReferences = remainingParts.tail
(option.dataType, optionalNestedReferences) match {
....
```
Which I think is equivalent to what you did, but calls out exactly what we
are matching on explicitly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
