Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2432#discussion_r18191371
--- Diff: core/src/main/java/org/apache/spark/ApplicationId.java ---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark;
+
+import java.io.Serializable;
+
+/**
+ * This class represents unique application id for identifying each
application
+ */
+public class ApplicationId implements Serializable {
+
+ private String appId;
+
+ public ApplicationId(String appId) {
+ this.appId = appId;
+ }
+
+ @Override
+ public boolean equals(Object other) {
+ if (!(other instanceof ApplicationId)) {
+ return false;
+ } else if (other == this) {
+ return true;
+ } else if (appId != null) {
+ return appId.equals(((ApplicationId)other).appId);
+ } else {
+ return false;
+ }
+ }
+
+ @Override
+ public int hashCode() {
+ return appId.hashCode();
+ }
+
+ @Override
+ public String toString() {
+ return appId;
+ }
+
+
+ private static ApplicationId defaultAppId =
+ new ApplicationId(String.valueOf(System.currentTimeMillis()));
--- End diff --
I don't think that we should have this field in `ApplicationId`. This will
always return the same application id, violating our uniqueness requirements.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
