Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18503#discussion_r125546491
  
    --- Diff: 
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/FixedLengthRowBasedKeyValueBatch.java
 ---
    @@ -62,7 +62,7 @@ public UnsafeRow appendRow(Object kbase, long koff, int 
klen,
     
         keyRowId = numRows;
         keyRow.pointTo(base, recordOffset, klen);
    -    valueRow.pointTo(base, recordOffset + klen, vlen + 4);
    +    valueRow.pointTo(base, recordOffset + klen, vlen + 8);
    --- End diff --
    
    Line 59 puts long value whose length is 8. In summary, line 57 and 59 
consumes `vlen + 8` bytes from `base + recordOffset+ klen`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to