Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18529#discussion_r125555875
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -588,12 +591,14 @@ case class MapObjects private(
case _ => genFunction.value
}
- val loopNullCheck = inputDataType match {
- case _: ArrayType => s"$loopIsNull =
${genInputData.value}.isNullAt($loopIndex);"
- // The element of primitive array will never be null.
- case ObjectType(cls) if cls.isArray &&
cls.getComponentType.isPrimitive =>
- s"$loopIsNull = false"
- case _ => s"$loopIsNull = $loopValue == null;"
+ val loopNullCheck = if (loopIsNull != "false") {
+ ctx.addMutableState("boolean", loopIsNull, "")
+ inputDataType match {
+ case _: ArrayType => s"$loopIsNull =
${genInputData.value}.isNullAt($loopIndex);"
+ case _ => s"$loopIsNull = $loopValue == null;"
--- End diff --
Hmm, it depends on if we correctly set `elementNullable` when calling
`MapObjects.apply` for all the cases.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
