GitHub user jiangxb1987 opened a pull request:

    https://github.com/apache/spark/pull/18540

    [SPARK-19451][SQL] rangeBetween method should accept Long value as boundary

    ## What changes were proposed in this pull request?
    
    Long values can be passed to `rangeBetween` as range frame boundaries, but 
we silently convert it to Int values, this can cause wrong results and we 
should fix this.
    
    Further more, we should accept any legal literal values as range frame 
boundaries. In this PR, we make it possible for Long values, and make accepting 
other DataTypes really easy to add.
    
    ## How was this patch tested?
    
    Add new tests in `DataFrameWindowFunctionsSuite` and `TypeCoercionSuite`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jiangxb1987/spark rangeFrame

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/18540.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #18540
    
----
commit 52c52895cfe3cae58f8b029a350949cc153971a7
Author: Xingbo Jiang <xingbo.ji...@databricks.com>
Date:   2017-07-05T09:02:51Z

    rangeBetween accept literal values.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to