Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/17995#discussion_r125606256
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -136,6 +137,14 @@ private[ml] object Param {
s"${this.getClass.getName} must override jsonDecode to support
its value type.")
}
}
+
+ /** Looks for the corresponding case-insensitive string option. */
+ def findStringOption(supportedValues: Array[String], value: String):
String = {
--- End diff --
I think this function is useless and involves extra computing cost.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
