Github user wzhfy commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16422#discussion_r125800773
  
    --- Diff: 
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
    @@ -262,7 +262,7 @@ describeFuncName
         ;
     
     describeColName
    -    : identifier ('.' (identifier | STRING))*
    +    : identifier
    --- End diff --
    
    That was my previous approach. As @cloud-fan mentioned in 
[#discussion_r122347812](https://github.com/apache/spark/pull/16422#discussion_r122347812)
 and 
[#discussion_r122348197](https://github.com/apache/spark/pull/16422#discussion_r122348197),
 it's hard to tell if "col.a" is a qualified name or a nested name, or maybe a 
more complex example:
    ```
    `a.b`.`c.d`
    ```
    ```
    `a.b.c.d`
    ```
    It may be very tricky to deal with such cases. What's your opinion?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to