Github user jinxing64 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18487#discussion_r125917832
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -321,6 +321,16 @@ package object config {
.intConf
.createWithDefault(3)
+ private[spark] val REDUCER_MAX_BLOCKS_IN_FLIGHT_PER_ADDRESS =
+ ConfigBuilder("spark.reducer.maxBlocksInFlightPerAddress")
--- End diff --
When shuffle service gets OOM, there are always lots of (thousands of)
reducers(maybe from different apps) fetching blocks. I'm not sure if it will
help much to limit in-flight blocks from reducer.
Also we've already have maxReqsInFlight and maxBytesInFlight. Is it little
bit redundant to to have maxBlocksInFlightPerAddress?
Sorry for this comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
