Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18565#discussion_r126301763
--- Diff:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/OneForOneBlockFetcher.java
---
@@ -58,29 +59,41 @@
private final BlockFetchingListener listener;
private final ChunkReceivedCallback chunkCallback;
private TransportConf transportConf = null;
- private File[] shuffleFiles = null;
+ private Boolean toDisk;
+ private Supplier<File> tmpFileCreater;
+ private Supplier<Boolean> shuffleBlockFetcherIteratorIsZombie;
private StreamHandle streamHandle = null;
public OneForOneBlockFetcher(
+ TransportClient client,
+ String appId,
+ String execId,
+ String[] blockIds,
+ BlockFetchingListener listener,
+ TransportConf transportConf) {
+ this(client, appId, execId, blockIds, listener, transportConf, false,
null, null);
+ }
+
+ public OneForOneBlockFetcher(
TransportClient client,
String appId,
String execId,
String[] blockIds,
BlockFetchingListener listener,
TransportConf transportConf,
- File[] shuffleFiles) {
+ Boolean toDisk,
+ Supplier<File> tmpFileCreater,
+ Supplier<Boolean> shuffleBlockFetcherIteratorIsZombie) {
--- End diff --
Since the network module doesn't depend on the core module, we should hide
the `ShuffleBlockFetcherIterator` from network module. How about we name it
`canCallerSideDeleteFile`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
