Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18581#discussion_r126453938
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/source/libsvm/LibSVMOptions.scala ---
@@ -41,11 +41,15 @@ private[libsvm] class LibSVMOptions(@transient private
val parameters: CaseInsen
case o => throw new IllegalArgumentException(s"Invalid value `$o` for
parameter " +
s"`$VECTOR_TYPE`. Expected types are `sparse` and `dense`.")
}
+
+ val lineSeparator: Option[String] = parameters.get(LINE_SEPARATOR)
--- End diff --
Yea, actually in case of Univocity, it requires 2 characters:
```
CsvWriterSettings settings = new CsvWriterSettings();
settings.getFormat().setLineSeparator("aaa");
```
```
Exception in thread "main" java.lang.IllegalArgumentException: Invalid line
separator. Up to 2 characters are expected. Got 3 characters.
at com.univocity.parsers.common.Format.setLineSeparator(Format.java:121)
at com.univocity.parsers.common.Format.setLineSeparator(Format.java:109)
```
I don't see a reason to restrict this for now. At least, I can provide an
usecase with Windows -`\r\n`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
