Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18592#discussion_r126614119
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/TPCDSQueryBenchmark.scala
 ---
    @@ -99,6 +99,13 @@ object TPCDSQueryBenchmark {
       }
     
       def main(args: Array[String]): Unit = {
    +    if (args.length < 1) {
    +      // scalastyle:off println
    +      println(
    +        "Usage: spark-submit --class <this class> --jars <spark sql test 
jar> <data location>")
    --- End diff --
    
    How about also printing the description below like;
    ```
        if (args.length < 1) {
          // scalastyle:off println
          println(
            s"""
               |Usage: spark-submit --class <this class> <spark sql test jar> 
<TPCDS data location>
               |
               |In order to run this benchmark, please follow the instructions 
at
               
|https://github.com/databricks/spark-sql-perf/blob/master/README.md to generate 
the TPCDS data
               |locally (preferably with a scale factor of 5 for benchmarking). 
Thereafter, the value of
               |dataLocation below needs to be set to the location where the 
generated data is stored.
             """.stripMargin)
          // scalastyle:on println
          System.exit(1)
        }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to