Github user liu-zhaokun commented on a diff in the pull request: https://github.com/apache/spark/pull/18599#discussion_r126639515 --- Diff: sbin/spark-daemon.sh --- @@ -78,6 +78,12 @@ spark_rotate_log () if [ -n "$2" ]; then num=$2 fi + + expr $num + 0 &>/dev/null + if [ $? -ne 0 ] || [ $num -eq 0 ]; then --- End diff -- @srowen Yes, we should avoid this scenario that num isn't number.If num isn't a number,num will be set to 5.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org