Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18555#discussion_r126660036
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -51,29 +62,65 @@ package object config {
ConfigBuilder(SparkLauncher.EXECUTOR_EXTRA_LIBRARY_PATH).stringConf.createOptional
private[spark] val EXECUTOR_USER_CLASS_PATH_FIRST =
-
ConfigBuilder("spark.executor.userClassPathFirst").booleanConf.createWithDefault(false)
+ ConfigBuilder("spark.executor.userClassPathFirst")
+ .doc("Same functionality as spark.driver.userClassPathFirst, " +
+ "but applied to executor instances.")
+ .booleanConf
+ .createWithDefault(false)
private[spark] val EXECUTOR_MEMORY =
ConfigBuilder("spark.executor.memory")
+ .doc("Amount of memory to use per executor process (e.g. 512, 1g, 2g,
8g).")
.bytesConf(ByteUnit.MiB)
+ .checkValue(v => v > 0 && v <= Int.MaxValue / 1024,
+ "The executor memory must be greater than 0 MiB " +
+ s"and less than ${Int.MaxValue / 1024} MiB.")
.createWithDefaultString("1g")
- private[spark] val IS_PYTHON_APP =
ConfigBuilder("spark.yarn.isPython").internal()
- .booleanConf.createWithDefault(false)
+ private[spark] val IS_PYTHON_APP = ConfigBuilder("spark.yarn.isPython")
+ .internal()
+ .booleanConf
+ .createWithDefault(false)
- private[spark] val CPUS_PER_TASK =
ConfigBuilder("spark.task.cpus").intConf.createWithDefault(1)
+ private[spark] val CPUS_PER_TASK = ConfigBuilder("spark.task.cpus")
+ .doc("Number of cores to allocate for each task. ")
--- End diff --
nit: remove space after `.`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
