GitHub user brkyvz opened a pull request: https://github.com/apache/spark/pull/18603
[SPARK-21370][SS] Add test for state reliability when one read-only state store aborts after read-write state store commits ## What changes were proposed in this pull request? During Streaming Aggregation, we have two StateStores per task, one used as read-only in `StateStoreRestoreExec`, and one read-write used in `StateStoreSaveExec`. `StateStore.abort` will be called for these StateStores if they haven't committed their results. We need to make sure that `abort` in read-only store after a `commit` in the read-write store doesn't accidentally lead to the deletion of state. This PR adds a test for this condition. ## How was this patch tested? This PR adds a test. You can merge this pull request into a Git repository by running: $ git pull https://github.com/brkyvz/spark ss-test Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/18603.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #18603 ---- commit 4783b124c365cde6a9398fc9278f8611aa4d7598 Author: Burak Yavuz <brk...@gmail.com> Date: 2017-07-11T22:27:41Z Added test for two concurrent state stores ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org