Github user 10110346 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18228#discussion_r126842852
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -1199,6 +1199,49 @@ case class Substring(str: Expression, pos:
Expression, len: Expression)
}
/**
+ * Returns the rightmost n characters from the string.
+ */
+// scalastyle:off line.size.limit
+@ExpressionDescription(
+ usage = "_FUNC_(str, len) - Returns the rightmost `len`(`len` can be
string type) characters from the string `str`,if `len` is less or equal than 0
the result is ``.",
+ extended = """
+ Examples:
+ > SELECT _FUNC_('Spark SQL', 3);
+ SQL
+ """)
+// scalastyle:on line.size.limit
+case class Right(str: Expression, len: Expression, child: Expression)
extends RuntimeReplaceable {
+ def this(str: Expression, len: Expression) = {
+ this(str, len, Substring(str, If(LessThanOrEqual(len, Literal(0)),
+ Literal(Integer.MAX_VALUE), UnaryMinus(len)), len))
--- End diff --
`right(null, -10)`
I agree with you, but , for this test case, there is a problem:
Which we expected is `null`,but it is an empty string
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
