Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18600#discussion_r126876170
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -354,36 +352,10 @@ case class DataSourceStrategy(conf: SQLConf) extends
Strategy with Logging with
val (unhandledPredicates, pushedFilters, handledFilters) =
selectFilters(relation.relation, candidatePredicates)
- // A set of column attributes that are only referenced by pushed down
filters. We can eliminate
- // them from requested columns.
- val handledSet = {
- val handledPredicates =
filterPredicates.filterNot(unhandledPredicates.contains)
- val unhandledSet =
AttributeSet(unhandledPredicates.flatMap(_.references))
- AttributeSet(handledPredicates.flatMap(_.references)) --
- (projectSet ++ unhandledSet).map(relation.attributeMap)
- }
-
// Combines all Catalyst filter `Expression`s that are either not
convertible to data source
// `Filter`s or cannot be handled by `relation`.
val filterCondition =
unhandledPredicates.reduceLeftOption(expressions.And)
- // These metadata values make scan plans uniquely identifiable for
equality checking.
- // TODO(SPARK-17701) using strings for equality checking is brittle
- val metadata: Map[String, String] = {
--- End diff --
The target of this cleanup PR is to remove the metadata...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
