Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18240353
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -328,10 +348,18 @@ private[spark] class ApplicationMaster(args:
ApplicationMasterArguments,
private def waitForSparkDriver(): ActorRef = {
logInfo("Waiting for Spark driver to be reachable.")
var driverUp = false
+ var count = 0
val hostport = args.userArgs(0)
val (driverHost, driverPort) = Utils.parseHostPort(hostport)
- while (!driverUp) {
+
+ // spark driver should already be up since it launched us, but we
don't want to
+ // wait forever, so wait 100 seconds max to match the cluster mode
setting.
+ // Leave this config unpublished for now.
+ val numTries =
sparkConf.getInt("spark.yarn.ApplicationMaster.client.waitTries", 1000)
--- End diff --
This config should use camel case for `applicationMaster`. Also, there's
already a `spark.yarn.applicationMaster.waitTries`. Does the extra `client`
mean it's for client mode? Do we want a separate setting for client vs deploy
modes here?
By the way there is a mismatch between what is already there
`spark.yarn.ApplicationMatser.waitTries` and what we document
`spark.yarn.applicationMaster.waitTries`. I think this is a bug that we can fix
separately.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
