Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/18281#discussion_r127552478 --- Diff: python/pyspark/ml/classification.py --- @@ -1511,27 +1512,47 @@ class OneVsRest(Estimator, OneVsRestParams, MLReadable, MLWritable): .. versionadded:: 2.0.0 """ + parallelism = Param(Params._dummy(), "parallelism", --- End diff -- Since this is a shared Param in Scala, do you want to make it one in Python too? You can add it to _shared_params_code_gen.py and then re-generate the shared.py file.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org