Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/18645#discussion_r127611350
--- Diff: core/src/main/scala/org/apache/spark/FutureAction.scala ---
@@ -89,6 +89,14 @@ trait FutureAction[T] extends Future[T] {
*/
override def value: Option[Try[T]]
+ // These two methods must be implemented in Scala 2.12, but won't be
used by Spark
+
+ def transform[S](f: (Try[T]) => Try[S])(implicit executor:
ExecutionContext): Future[S] =
--- End diff --
These cause a MiMa warning, because they're new methods in a trait that
might be extended by users. I'll have to go back and remember whether this is
an actual problem, because the trait is providing a default implementation here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
