Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/18630#discussion_r127614182
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/DriverWrapper.scala ---
@@ -66,4 +75,50 @@ object DriverWrapper {
System.exit(-1)
}
}
+
+ // R or Python are not supported in cluster mode so just get jars and
files for the driver
+ private def setupDependencies(loader: MutableURLClassLoader, userJar:
String): Unit = {
+
+ var packagesExclusions = sys.props.get("spark.jars.excludes").orNull
+ var packages = sys.props.get("spark.jars.packages").orNull
+ var repositories = sys.props.get("spark.jars.repositories").orNull
+ val hadoopConf = new HadoopConfiguration()
+ val childClasspath = new ArrayBuffer[String]()
+ var jars = sys.props.get("spark.jars").orNull
--- End diff --
Ivy does the resolution and downloads them locally at the file system's
node where the driver is launched on. So then you use the hadoop utilities to
fetch them. That's the idea about jars. I was only focusing on packages... but
yes need to write some more code to handle files and remote jars already passed
though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
