Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18654#discussion_r127722734
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala
---
@@ -236,7 +236,10 @@ object FileFormatWriter extends Logging {
committer.setupTask(taskAttemptContext)
val writeTask =
- if (description.partitionColumns.isEmpty &&
description.bucketIdExpression.isEmpty) {
+ if (sparkPartitionId != 0 && !iterator.hasNext) {
--- End diff --
I guess this might be okay in that sense we are guaranteed partitions to be
started from 0 up to my knowledge. Could you take a look and see if it makes
sense to you cc @cloud-fan if you don't mind? I am not confident enough to
proceed reviewing and leave a sign-off.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
