Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/18468
I think this PR doesn't have a good abstraction of the problem. For table
cache, our goal is not making the comressed data a `ColumnVector`, but having
an efficient way to convert the compressed data(byte array) to `ColumnVector`.
I think the most efficient way is to not do conversion at all, but having a
wrapper, i.e. having a `class CachedBatchColumnVector(data: Array[Byte])`,
which implements various `getXXX` methods by doing decompression. Then we don't
need to introduce the `VectorType` concept and change `ColumnVector`.
@kiszk what do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
