Github user jiangxb1987 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18639#discussion_r127898848
  
    --- Diff: core/src/main/scala/org/apache/spark/rpc/netty/Dispatcher.scala 
---
    @@ -33,7 +33,7 @@ import org.apache.spark.util.ThreadUtils
     /**
      * A message dispatcher, responsible for routing RPC messages to the 
appropriate endpoint(s).
      */
    -private[netty] class Dispatcher(nettyEnv: NettyRpcEnv) extends Logging {
    +private[netty] class Dispatcher(nettyEnv: NettyRpcEnv, numUsableCores: 
Int) extends Logging {
    --- End diff --
    
    Should we document the behavior when `numUsableCores` is set to 0 in the 
comment above?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to