Github user QCTW commented on a diff in the pull request:
https://github.com/apache/spark/pull/15471#discussion_r127771891
--- Diff: R/pkg/R/backend.R ---
@@ -108,13 +108,27 @@ invokeJava <- function(isStatic, objId, methodName,
...) {
conn <- get(".sparkRCon", .sparkREnv)
writeBin(requestMessage, conn)
- # TODO: check the status code to output error information
returnStatus <- readInt(conn)
+ handleErrors(returnStatus, conn)
+
+ # Backend will send -1 as keep alive value to prevent various connection
timeouts
+ # on very long running jobs. See spark.r.heartBeatInterval
+ while (returnStatus == 1) {
--- End diff --
Shoudn't it have a retry limit for the returnStatus check to avoid infinite
loop?
I have an infinite loop when the it is called by Toree sparkr_runner.R with
error message "Failed to connect JVM: Error in socketConnection(host =
hostname, port = port, server = FALSE, : argument "timeout" is missing, with no
default"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
