Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/18672#discussion_r128073513
--- Diff:
external/kafka-0-10/src/main/scala/org/apache/spark/streaming/kafka010/DirectKafkaInputDStream.scala
---
@@ -130,8 +130,15 @@ private[spark] class DirectKafkaInputDStream[K, V](
offsets: Map[TopicPartition, Long]): Option[Map[TopicPartition, Long]]
= {
val estimatedRateLimit = rateController.map(_.getLatestRate())
+ // TODO: Fix in rate controller (need SparkConf or initial rate member
value)
+ // Fix: Rate controller first value is -1, if -1 return use the
default rate
+ val fixedEstimatedRateLimit = estimatedRateLimit match {
--- End diff --
This looks like a bit of a hack. Can you explain this? what's the right fix
if so?
See http://spark.apache.org/contributing.html too
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
