Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18503#discussion_r128133349
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala
---
@@ -350,20 +350,24 @@ private[state] class HDFSBackedStateStoreProvider
extends StateStoreProvider wit
throw new IOException(
s"Error reading delta file $fileToRead of $this: key size
cannot be $keySize")
} else {
- val keyRowBuffer = new Array[Byte](keySize)
+ // If key size in an existing file is not a multiple of 8, round
it to multiple of 8
--- End diff --
I don't think we can round. Assume the actual length of an unsafe row is 8,
and previously we will append 4 bytes and have an unsafe row with 12 bytes, and
save it to checkpoint. So here, when we reading old checkppint, we need to read
12 bytes, and set the length to 8.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
