Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18680#discussion_r128268438
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ArrowColumnVector.java
---
@@ -0,0 +1,510 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.vectorized;
+
+import org.apache.arrow.vector.*;
+import org.apache.arrow.vector.complex.*;
+import org.apache.arrow.vector.holders.NullableVarCharHolder;
+
+import org.apache.spark.memory.MemoryMode;
+import org.apache.spark.sql.execution.arrow.ArrowUtils;
+import org.apache.spark.sql.types.*;
+import org.apache.spark.unsafe.types.UTF8String;
+
+/**
+ * A column backed by Apache Arrow.
+ */
+public final class ArrowColumnVector extends ColumnVector {
+
+ private ValueVector vector;
+ private ValueVector.Accessor nulls;
+
+ private NullableBitVector boolData;
+ private NullableTinyIntVector byteData;
+ private NullableSmallIntVector shortData;
+ private NullableIntVector intData;
+ private NullableBigIntVector longData;
+
+ private NullableFloat4Vector floatData;
+ private NullableFloat8Vector doubleData;
+ private NullableDecimalVector decimalData;
+
+ private NullableVarCharVector stringData;
+
+ private NullableVarBinaryVector binaryData;
+
+ private UInt4Vector listOffsetData;
+
+ public ArrowColumnVector(ValueVector vector) {
+ super(vector.getValueCapacity(), DataTypes.NullType,
MemoryMode.OFF_HEAP);
+ initialize(vector);
+ }
+
+ @Override
+ public long nullsNativeAddress() {
+ throw new RuntimeException("Cannot get native address for arrow
column");
+ }
+
+ @Override
+ public long valuesNativeAddress() {
+ throw new RuntimeException("Cannot get native address for arrow
column");
+ }
+
+ @Override
+ public void close() {
+ if (childColumns != null) {
+ for (int i = 0; i < childColumns.length; i++) {
+ childColumns[i].close();
+ }
+ }
+ vector.close();
+ }
+
+ //
+ // APIs dealing with nulls
+ //
+
+ @Override
+ public void putNotNull(int rowId) {
+ throw new UnsupportedOperationException();
+ }
+
+ @Override
+ public void putNull(int rowId) {
+ throw new UnsupportedOperationException();
+ }
+
+ @Override
+ public void putNulls(int rowId, int count) {
+ throw new UnsupportedOperationException();
+ }
+
+ @Override
+ public void putNotNulls(int rowId, int count) {
+ throw new UnsupportedOperationException();
+ }
+
+ @Override
+ public boolean isNullAt(int rowId) {
+ return nulls.isNull(rowId);
+ }
+
+ //
+ // APIs dealing with Booleans
+ //
+
+ @Override
+ public void putBoolean(int rowId, boolean value) {
+ throw new UnsupportedOperationException();
+ }
+
+ @Override
+ public void putBooleans(int rowId, int count, boolean value) {
+ throw new UnsupportedOperationException();
+ }
+
+ @Override
+ public boolean getBoolean(int rowId) {
+ return boolData.getAccessor().get(rowId) == 1;
+ }
+
+ @Override
+ public boolean[] getBooleans(int rowId, int count) {
+ assert(dictionary == null);
+ NullableBitVector.Accessor accessor = boolData.getAccessor();
--- End diff --
I see. Can we keep `NullableBitVector.Accessor` instead of
`NullableBitVector` while we keep the same reference in two instance variables.
I am afraid about the cost of runtime cast in `getBoolean()` method rather than
`getBooleans()` method.
This is why I expect `get()` method will be inlined into by a JIT compiler
since each Accessor class is `final`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
