Github user MLnick commented on the issue:

    https://github.com/apache/spark/pull/18612
  
    It makes sense for `LinearSVC` since the threshold has the same meaning for 
other binary classifiers (e.g. LogisticRegression). The meaning of threshold 
for `Binarizer` is very different as it operates on feature values in a feature 
vector, not raw predicted values from a model. I would say back out the 
Binarizer changes here.
    
    As for GBT, well I am sort of indifferent as the step size is roughly 
analogous between the two definitions (in both cases it is a learning rate).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to