Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18388#discussion_r128755064 --- Diff: common/network-common/src/main/java/org/apache/spark/network/server/StreamManager.java --- @@ -83,4 +83,16 @@ public void connectionTerminated(Channel channel) { } */ public void checkAuthorization(TransportClient client, long streamId) { } + /** + * Return the number of chunks being transferred and not finished yet in this StreamManager. + */ + public long chunksBeingTransferred() { + return 0; + } + + /** + * Called when a chunk is successfully sent. + */ + public void chunkSent(long streamId) { } --- End diff -- I think it makes more sense to have 2 methods: ``` chunkSent(long streamId); streamSent(String streamId); ```
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org