Github user chouqin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2595#discussion_r18260795
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala ---
@@ -437,6 +433,7 @@ object DecisionTree extends Serializable with Logging {
* @param treeToNodeToIndexInfo Mapping: treeIndex --> nodeIndex -->
nodeIndexInfo,
* where nodeIndexInfo stores the index in
the group and the
* feature subsets (if using feature
subsets).
+ * @param nodeToFeatures Mapping: nodeIndexInGroup -> feature subsets
--- End diff --
yes, this is a duplication, but as described in the documentation of
`RandomForest.selectNodesToSplit`, it is a shortcut for to find feature indices
a node given node index in group.
Maybe we can construct `nodeToFeatures` in `DecisionTree.findBestSplits`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
