Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18540#discussion_r128894061
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -43,58 +42,54 @@ case class WindowSpecDefinition(
orderSpec: Seq[SortOrder],
frameSpecification: WindowFrame) extends Expression with WindowSpec
with Unevaluable {
- def validate: Option[String] = frameSpecification match {
- case UnspecifiedFrame =>
- Some("Found a UnspecifiedFrame. It should be converted to a
SpecifiedWindowFrame " +
- "during analysis. Please file a bug report.")
- case frame: SpecifiedWindowFrame => frame.validate.orElse {
- def checkValueBasedBoundaryForRangeFrame(): Option[String] = {
- if (orderSpec.length > 1) {
- // It is not allowed to have a value-based PRECEDING and
FOLLOWING
- // as the boundary of a Range Window Frame.
- Some("This Range Window Frame only accepts at most one ORDER BY
expression.")
- } else if (orderSpec.nonEmpty &&
!orderSpec.head.dataType.isInstanceOf[NumericType]) {
- Some("The data type of the expression in the ORDER BY clause
should be a numeric type.")
- } else {
- None
- }
- }
-
- (frame.frameType, frame.frameStart, frame.frameEnd) match {
- case (RangeFrame, vp: ValuePreceding, _) =>
checkValueBasedBoundaryForRangeFrame()
- case (RangeFrame, vf: ValueFollowing, _) =>
checkValueBasedBoundaryForRangeFrame()
- case (RangeFrame, _, vp: ValuePreceding) =>
checkValueBasedBoundaryForRangeFrame()
- case (RangeFrame, _, vf: ValueFollowing) =>
checkValueBasedBoundaryForRangeFrame()
- case (_, _, _) => None
- }
- }
- }
-
- override def children: Seq[Expression] = partitionSpec ++ orderSpec
+ override def children: Seq[Expression] = partitionSpec ++ orderSpec ++
Seq(frameSpecification)
--- End diff --
nit: `partitionSpec ++ orderSpec :+ frameSpecification`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
