Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/18503#discussion_r129465467
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala
---
@@ -363,7 +363,11 @@ private[state] class HDFSBackedStateStoreProvider
extends StateStoreProvider wit
val valueRowBuffer = new Array[Byte](valueSize)
ByteStreams.readFully(input, valueRowBuffer, 0, valueSize)
val valueRow = new UnsafeRow(valueSchema.fields.length)
- valueRow.pointTo(valueRowBuffer, valueSize)
+ // If valueSize in existing file is not multiple of 8, floor
it to multiple of 8.
+ // This is work around for the following.
+ // Pre-Spark 2.3 mistakenly append 4 bytes to the value row in
+ // `FixedLengthRowBasedKeyValueBatch`, which gets persisted
into the checkpoint data
+ valueRow.pointTo(valueRowBuffer, (valueSize / 8) * 8)
--- End diff --
@cloud-fan @kiszk Just to confirm again, are we absolutely sure that the
issue is that there 4 extra bytes in checkpointed rows, and therefore this
truncation is safe to do?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
