Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18735#discussion_r129613952
  
    --- Diff: docs/configuration.md ---
    @@ -635,7 +635,10 @@ Apart from these, the following properties are also 
available, and may be useful
       <td><code>spark.shuffle.maxChunksBeingTransferred</code></td>
       <td>Long.MAX_VALUE</td>
       <td>
    -    The max number of chunks allowed to being transferred at the same time 
on shuffle service.
    +    The max number of chunks allowed to be transferred at the same time on 
shuffle service.
    +    Note that new incoming connections will be closed when the max number 
is hit. The client will
    +    retry according to the shuffle retry configs (see 
spark.shuffle.io.maxRetries and
    +    spark.shuffle.io.retryWait), if those limits are reached the task will 
fail with fetch failure.
    --- End diff --
    
    thanks for updating, sorry I forgot to ask you to put 
spark.shuffle.io.maxRetries and spark.shuffle.io.retryWait  inside 
<code></code> so they show up as references like in other places.  See the 
description of 
    spark.shuffle.compress
     as an example on how ti references other configs.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to