Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18610#discussion_r129997548
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -309,6 +313,23 @@ private[ml] object DefaultParamsWriter {
val metadataJson: String = compact(render(metadata))
metadataJson
}
+
+ /**
+ * Save estimator's `initialModel` to corresponding path.
+ */
+ def saveInitialModel[T <: HasInitialModel[_ <: MLWritable with Params]](
+ instance: T, path: String): Unit = {
+ if (instance.isDefined(instance.initialModel)) {
+ val initialModelPath = new Path(path, "initialModel").toString
+ val initialModel = instance.getOrDefault(instance.initialModel)
+ // When saving, only keep the direct initialModel by eliminating
possible initialModels of the
+ // direct initialModel, to avoid unnecessary deep recursion of
initialModel.
+ if (initialModel.hasParam("initialModel")) {
+ initialModel.clear(initialModel.getParam("initialModel"))
+ }
+ initialModel.save(initialModelPath)
--- End diff --
Actually we did in the later way, ```initialModel``` is only param for
Estimator, not for Model. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
