Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18725#discussion_r130021324
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -495,6 +495,23 @@ object ColumnPruning extends Rule[LogicalPlan] {
// Eliminate no-op Projects
case p @ Project(_, child) if sameOutput(child.output, p.output) =>
child
+ // The column of father project contains not deterministic function
+ // e.g Rand function. father project will be split to two project.
+ case h @ Project(fields, _: LeafNode) if
!fields.forall(_.deterministic) =>
--- End diff --
I meant, in all the cases projectList contains non-deterministic expr, do
we always need to split the project on all kinds of LeafNode?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
